139 inmemory clear mode sa encryption is off by 2 bytes used in unit tests #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dccutrig
commented
Jun 22, 2023
There was a problem hiding this comment.
Tangential to this: Is there a case to take SA_PLAINTEXT and other things defined in crypto_config.h and change them to enums vs #defines?
There was a problem hiding this comment.
Yeah I think so, we should work on that consistency across the board. Can likely accomplish as part of #129
Codecov Report
@@ Coverage Diff @@
## dev #173 +/- ##
==========================================
+ Coverage 86.12% 86.18% +0.06%
==========================================
Files 29 29
Lines 7890 7896 +6
==========================================
+ Hits 6795 6805 +10
+ Misses 1095 1091 -4
|
jlucas9
approved these changes
Jun 22, 2023
jlucas9
deleted the
139-inmemory-clear-mode-sa-encryption-is-off-by-2-bytes-used-in-unit-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.